Skip to content

Update PLE2510, PLE2512-2515 to check in f-strings#7387

Merged
dhruvmanila merged 1 commit intodhruv/pep-701from
dhruv/issue-7296
Sep 16, 2023
Merged

Update PLE2510, PLE2512-2515 to check in f-strings#7387
dhruvmanila merged 1 commit intodhruv/pep-701from
dhruv/issue-7296

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Sep 14, 2023 •
edited
Loading

Summary

This PR updates PLE2510, PLE2512-2515 to check in f-strings.

Reference:

  • PLE2510: Invalid unescaped character backspace, use "\b" instead
  • PLE2512: Invalid unescaped character SUB, use "\x1A" instead
  • PLE2513: Invalid unescaped character ESC, use "\x1B" instead
  • PLE2514: Invalid unescaped character NUL, use "\0" instead
  • PLE2515: Invalid unescaped character zero-width-space, use "\u200B" instead

Test Plan

Add test cases for f-strings.

@dhruvmanila
Copy link
Member Author

dhruvmanila commented Sep 14, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila mentioned this pull request Sep 14, 2023
Merged
@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule python312 Related to Python 3.12 labels Sep 14, 2023
@dhruvmanila dhruvmanila linked an issue Sep 14, 2023 that may be closed by this pull request
Update PLE2510, PLE2512-2515 to check in f-strings #7296
Closed
MichaReiser
MichaReiser approved these changes Sep 15, 2023
View reviewed changes
crates/ruff/resources/test/fixtures/pylint/invalid_characters.py
Copy link
Member

@MichaReiser MichaReiser Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, why is this a binary file 😕

Copy link
Member Author

@dhruvmanila dhruvmanila Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, locally I don't see it:

$ ls -la invalid_characters*
-rw-r--r--@ 1 dhruv  staff   1.4K Sep 15 12:02 invalid_characters.py

I guess it's GitHub getting confused although not sure. This is what I see inside the editor:

Screenshot 2023-09-15 at 12 02 44

Copy link
Member Author

@dhruvmanila dhruvmanila Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And is also visible in the branch: https://github.com/astral-sh/ruff/blob/dhruv/issue-7296/crates/ruff/resources/test/fixtures/pylint/invalid_characters.py

@dhruvmanila dhruvmanila merged commit e53db6c into dhruv/pep-701 Sep 16, 2023
@dhruvmanila dhruvmanila deleted the dhruv/issue-7296 branch September 16, 2023 08:11
dhruvmanila added a commit that referenced this pull request Sep 18, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
8e92f64 
## Summary

This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

## Test Plan

Add test cases for f-strings.
This was referenced Sep 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
dhruvmanila added a commit that referenced this pull request Sep 19, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
dd8c9f7 
## Summary

This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

## Test Plan

Add test cases for f-strings.
@dhruvmanila dhruvmanila mentioned this pull request Sep 19, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 20, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
4267d79 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 21, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
4f6b1f9 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
af4b4de 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
e873ca2 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
This was referenced Sep 22, 2023
Merged
Merged
Merged
dhruvmanila added a commit that referenced this pull request Sep 22, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
a8662a0 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
@dhruvmanila dhruvmanila mentioned this pull request Sep 22, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 26, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
4318ab1 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
@dhruvmanila dhruvmanila mentioned this pull request Sep 26, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 27, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
c0724af 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 28, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
a65779f 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
@dhruvmanila dhruvmanila mentioned this pull request Sep 28, 2023
Merged
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
37b8a93 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
dhruvmanila added a commit that referenced this pull request Sep 29, 2023
@dhruvmanila
Update PLE2510, PLE2512-2515 to check in f-strings (#7387)
402ac49 
This PR updates `PLE2510`, `PLE2512-2515` to check in f-strings.

> ### Reference:
> * `PLE2510`: Invalid unescaped character backspace, use "\b" instead
> * `PLE2512`: Invalid unescaped character SUB, use "\x1A" instead
> * `PLE2513`: Invalid unescaped character ESC, use "\x1B" instead
> * `PLE2514`: Invalid unescaped character NUL, use "\0" instead
> * `PLE2515`: Invalid unescaped character zero-width-space, use
"\u200B" instead

Add test cases for f-strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees

No one assigned

Labels

python312 Related to Python 3.12 rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update PLE2510, PLE2512-2515 to check in f-strings

2 participants

@dhruvmanila @MichaReiser